Tests#3
Open
JohnFF wants to merge 20 commits into
Open
Conversation
…mail Addresses. 2. Made separate swear filter tool. 3. Added tool to clean invalid responses. 4. Added interface to do the translation. This commit is a culmination of the work done by John Kirk, at and for Future First, including contributions from David Knoll (david@futurefirst.org.uk).
2. Changed some ChainSMSTranslations to include parameters correctly. 3. Changed the URLs to be consistent.
…idate Includes: 1. Added additional generic SMS Survey translation options: Gender, Email Addresses. 2. Made separate swear filter tool. 3. Added tool to clean invalid responses. 4. Added interface to do the translation. This commit is a culmination of the work done by John Kirk, at and for Future First, including contributions from David Knoll (david@futurefirst.org.uk). And JohnFF's changes: 1. Follow up message no longer sent if a swear is detected. 2. Changed some ChainSMSTranslations to include parameters correctly. 3. Changed the URLs to be consistent.
Added create chainsms answers table upon install, remove upon uninstall.
Remove old run file and switched maintainer (on MM's say so)
SQL Function Tidying Drop table only if it exists. Ran standards fixer on affected files.
Made translator description visible in the interface. Added a button for if there are no chains.
Made URLs consistent. Made translator description visible in the interface. Added a button for if there are no chains. Ran standards compliance and remove trailing whitespace on changed files.
Credit to Nicolas.
Update README.md
Updated queries and implemented review items from Nicolas' feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Tests to cover:
Leaving Year Translator
Email Address Translator
FF Tracking Survey Translator