feat(routing): add A* geographic heuristic - #7
Open
404khai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinaryHeap, best-cost tracking, predecessor reconstruction, and deterministic tie-breakingRouteResultHeuristic correctness
For the selected model and context:
Every traversable edge cost is bounded below by its scaled geographic distance. Combined with the Haversine triangle inequality, this keeps the heuristic admissible and consistent. Graphs without positive geographic span use a zero heuristic and safely fall back to Dijkstra search order.
Benchmark findings
The deterministic geographic benchmark verified identical optimal paths and costs. A* finalized 90% fewer nodes at 1K, 10K, and 100K nodes. End-to-end median latency was still 44.3%, 40.8%, and 23.7% slower because heuristic preparation is included in every routing call. The PR records this tradeoff and does not claim an unmeasured speedup.
Memory is explicitly marked unmeasured because no controlled allocator or profiler is configured.
Verification
cargo fmt --all -- --checkcargo test --workspace --all-features --lockedcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo bench -p roadrunner-core --bench astar --locked