ci(prod-deploy): 本番にもGo関数デプロイ工程を追加（dev同等・本番設定）#134
Merged
Conversation
prod-deploy.ymlはfirebase deploy(フロント+Node関数)のみで、Go関数(userOGPGo等)を 一切デプロイしていなかった。これではenv/prodへ反映してもGo移植が本番に出ない。 dev-deploy.ymlと同等の工程を本番設定で移植する: - go build/vet + Firestoreエミュレータ統合テスト(デプロイ前ゲート) - OGPサンプルQCアーティファクト生成 - GCPサービス有効化・Pub/Subトピック作成・OAuth/base_url取得・App Engineロケーション解決 - 全Go関数(HTTP6+スケジュール4)の並列デプロイ + Cloud Schedulerジョブ作成/更新 本番固有値: project=d-shrine, bucket=d-shrine.appspot.com, SANPAI_NEXT_TIME_SECONDS=300, OGP_PROJECT_ID=d-shrine (Node版 buggetName=projectID+.appspot.com / next_time=300 と一致) Co-authored-by: kojira <kojira@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景（重大な欠陥の修正）
prod-deploy.ymlはfirebase deploy（フロント＋Node関数）のみで、Go関数（userOGPGo/statusGo等）を一切デプロイしていなかった。このままだとenv/dev → env/prod（#130）を反映しても、Go移植は本番に反映されない（プロモーション経路が未完成）。dev にだけ Go デプロイを入れて本番へ入れ忘れていた私のミス。変更
dev-deploy.ymlと同等の工程をprod-deploy.ymlに本番設定で移植:go build/go vet＋ Firestoreエミュレータ統合テスト（デプロイ前ゲート）ogp-sample）本番固有値（dev との差分）
d-shrine-devd-shrineSTORAGE_BUCKET_NAMEd-shrine-dev.appspot.comd-shrine.appspot.comSANPAI_NEXT_TIME_SECONDS60300OGP_PROJECT_IDd-shrine-devd-shrineDEV_GCLOUD_SERVICE_KEYPROD_GCLOUD_SERVICE_KEYNode版の
buggetName = ${projectID}.appspot.com/next_time = (projectID=='d-shrine')?300:60と一致。検証
actionlint .github/workflows/prod-deploy.yml（および dev）: パス。プロモーション順序（重要）
この修正が env/prod に入った状態で
env/dev → env/prodを反映して初めて Go関数が本番デプロイされる。したがって: 本PR →main→env/dev→env/prod(#130) の順で反映する。