鈴を鳴らした直後の誤スキップを防止(1.5秒の猶予)#193
Merged
Merged
Conversation
鳴った瞬間にphaseがcascadeへ切り替わるため、鈴を鳴らしたジェスチャーの 指離し(touchend)や勢い余った直後のタップがスキップ判定に食われて 即結果表示になっていた(#190でtouchendを拾うようになり顕在化)。 鳴ってから1.5秒はスキップを武装しない。 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DwkB6Hj2JggoKcy7FoxNcU
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
kojira
pushed a commit
that referenced
this pull request
Jul 20, 2026
kojira
pushed a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原因
鈴が鳴った瞬間に phase が
cascadeに切り替わるため、鈴を鳴らしたジェスチャーの指離し(touchend)や勢い余った直後のタップがそのままスキップ判定に食われて即結果表示になっていた。#190 で touchend を拾うようになったことで顕在化。修正
鳴ってから 1.5秒はスキップを武装しない(
_skipArmedAt)。玉の投入は鳴ってから300ms後なので、演出の冒頭を見逃すことなく誤爆だけ防げる。1.5秒経過後は従来どおり全画面タップでスキップ可能。yarn generate成功。実機確認はdevで(鈴を鳴らした直後に連打しても結果が飛ばないこと/少し待ってからのタップでスキップできること)。🤖 Generated with Claude Code
https://claude.ai/code/session_01DwkB6Hj2JggoKcy7FoxNcU
Generated by Claude Code