Extract hardcoded UI strings to resources to enable english language localization - #3
Extract hardcoded UI strings to resources to enable english language localization#3Jake-Taylor02 wants to merge 1 commit into
Conversation
|
Hi Jake, thank you for the contribution and for opening this as a draft first! Yes, I would like to pursue English localization. Making the application usable for people who cannot read Chinese is a valuable improvement. For this first PR, please keep the scope focused on the startup and login flow. You do not need to translate the entire game in one PR, and the existing issues #1 and #2 are unrelated to this change. I reviewed the current commit and found a few things to address before marking it ready for review:
Once these are complete and CI passes, please mark the PR as ready for review. Thanks again for helping make the project accessible to more users! |
|
Hi Jake, thank you again for identifying the localization gap and opening this draft. To keep the project moving, I have now completed an independent, repository-wide localization implementation on Because |
What changed
Why
I wanted to contribute to this project but I can't read Chinese!
Extracting hard-coded UI text to properties will allow the application to be used in multiple languages.
I've only done the login panel before opening this PR in case you're not interested in the change.
Please let me know what you think @44-99 and whether you want to pursue this feature.
Screenshots or metrics