Unify reduced lung test mesh construction - #2237
Merged
maxiludwig merged 1 commit intoAug 31, 2026
Merged
Conversation
The junction and boundary condition tests built their meshes from RedAirway elements, which they only used as generic line2 elements. They now share the mesh helpers of the helpers test, which build through the production discretization builder instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
davidrudlstorfer
approved these changes
Aug 31, 2026
lkoeglmeier
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
The junction and boundary condition tests built their meshes from
Discret::Elements::RedAirway, which they only used as a generic two-node line element.They now share the mesh helpers of
4C_reduced_lung_helpers_test.cpp, which move into the shared test utils and build viabuild_discretization_from_nodes_and_elementslike the production code does.This removes an undeclared dependency of the reduced lung tests on
red_airways, along with three near-duplicate mesh helpers.Disclosure of AI assistance
The changes in this PR were made by Claude Opus 5.