Refactor FlowMeasure to use dynamic maps and shared locks - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR fixes a critical crash in the UPF pod that occurs when the flow_measure module is enabled during UE attachment.
The previous implementation relied on a fixed-size DPDK rte_hash and a separate std::vector for statistics. This architecture was prone to crashes under high-concurrency scenarios (like a burst of UEs attaching) due to:
Changes made to resolve the crash:
Which issue(s) this PR fixes:
Fixes #32
Test Report Added?:
Test Report:
NA
Special notes for your reviewer:
The refactor focuses on moving away from fixed-size DPDK structures to more robust C++ standard containers. This provides the necessary memory safety and locking granularity to handle the bursty nature of UE attachment signaling. The get_or_create logic is the core of the fix, ensuring safe, atomic creation of new flow entries.