Fix releaseTunnel() race condition affecting PFCP Session Deletion Response handling - #84
Open
anaswarac-dac wants to merge 1 commit into
Open
Fix releaseTunnel() race condition affecting PFCP Session Deletion Response handling#84anaswarac-dac wants to merge 1 commit into
anaswarac-dac wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR fixes a race condition during PFCP session deletion in releaseTunnel().
Previously, PendingUPF entries were added and PFCP Session Deletion Requests were sent in the same loop. If a UPF responded quickly, the response handler could remove that UPF from PendingUPF before the remaining UPFs had been added. This could cause PendingUPF.IsEmpty() to become true prematurely, resulting in session cleanup being triggered before all PFCP Session Deletion Responses were received.
To eliminate this race, the release process is split into two phases:
Populate the complete PendingUPF map for all unique UPFs.
Send PFCP Session Deletion Requests only after PendingUPF has been fully populated.
This guarantees that PendingUPF.IsEmpty() becomes true only after responses from all expected UPFs have been processed, preventing premature session cleanup and avoiding intermittent session establishment failures observed during longevity testing.
Which issue(s) this PR fixes:
Fixes #83
Test Report Added?:
Test Report:
Special notes for your reviewer: