Fix resync and sequence number logic in authentication procedure. - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR refactors the GenerateAuthDataProcedure in UDM to improve code maintainability and resolve SonarQube code quality issues. It modularizes the authentication logic into distinct functions for credential derivation, sequence number management, and vector building. Crucially, it ensures cryptographic synchronization of the SQN and RAND variables across these modules to fix a regression where AUTN verification failed during resynchronization and standard authentication flows.
Which issue(s) this PR fixes:
Fixes #32
Test Report Added?:
Test Report:
NA
Special notes for your reviewer:
NIL