Skip to content

SonarQube Vulnerability Critical Fixes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReshmaJS wants to merge 3 commits into
base: cdacmaster
Choose a base branch
from
Open

SonarQube Vulnerability Critical Fixes #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b64784
sonarqubefixes except nc,py files
Apr 28, 2026
2e28e1d
lint error fixed
May 6, 2026
4417a36
lint error fixed
May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions conf/test_route_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
fetch_mac, mac_to_hex, mac_to_int,
validate_ipv4)


DEFAULT_MAC_ADDRESS = "00:1a:2b:3c:4d:5e"
class BessControllerMock(object):
"""Mock of BessController to avoid using BESS from pybess.bess"""

Expand Down Expand Up @@ -71,7 +71,7 @@ def test_given_invalid_ip_when_validate_ipv6_then_returns_false(self):
self.assertFalse(validate_ipv4(""))

def test_given_valid_mac_when_mac_to_int_then_returns_int_representation(self):
self.assertEqual(mac_to_int("00:1a:2b:3c:4d:5e"), 112394521950)
self.assertEqual(mac_to_int(DEFAULT_MAC_ADDRESS ), 112394521950)

def test_given_invalid_mac_when_mac_to_int_then_raises_exception(self):
with self.assertRaises(ValueError):
Expand All @@ -80,17 +80,17 @@ def test_given_invalid_mac_when_mac_to_int_then_raises_exception(self):
def test_given_valid_mac_when_mac_to_hex_then_return_hex_string_representation(
self,
):
self.assertEqual(mac_to_hex("00:1a:2b:3c:4d:5e"), "001A2B3C4D5E")
self.assertEqual(mac_to_hex(DEFAULT_MAC_ADDRESS ), "001A2B3C4D5E")

def test_given_known_destination_when_fetch_mac_then_returns_mac(self):
ndb = Mock()
kwargs = {
"ifindex": 1,
"dst": "192.168.1.1",
"lladdr": "00:1a:2b:3c:4d:5e"
"lladdr": DEFAULT_MAC_ADDRESS
}
ndb.neighbours.dump.return_value = [kwargs]
self.assertEqual(fetch_mac(ndb, "192.168.1.1"), "00:1a:2b:3c:4d:5e")
self.assertEqual(fetch_mac(ndb, "192.168.1.1"), DEFAULT_MAC_ADDRESS)

def test_given_unknown_destination_when_fetch_mac_then_returns_none(self):
ndb = Mock()
Expand Down Expand Up @@ -132,13 +132,13 @@ def add_route_entry(
kwargs = {
"ifindex": 1,
"dst": "192.168.1.1",
"lladdr": "00:1a:2b:3c:4d:5e"
"lladdr": DEFAULT_MAC_ADDRESS
}
self.ndb.neighbours.dump.return_value = [kwargs]
mock_get_update_module_name.return_value = "merge_module"
mock_get_route_module_name.return_value = "route_module"
mock_get_merge_module_name.return_value = "update_module"
mock_fetch_mac.return_value = "00:1a:2b:3c:4d:5e"
mock_fetch_mac.return_value = DEFAULT_MAC_ADDRESS
self.route_controller.add_new_route_entry(route_entry)
return route_entry

Expand Down Expand Up @@ -257,7 +257,7 @@ def test_given_valid_new_route_when_add_new_route_entry_and_mac_known_then_route
kwargs = {
"ifindex": 1,
"dst": "192.168.1.1",
"lladdr": "00:1a:2b:3c:4d:5e"
"lladdr": DEFAULT_MAC_ADDRESS
}
self.ndb.neighbours.dump.return_value = [kwargs]
mock_routes = [{"event": "RTM_NEWROUTE"}, {"event": "OTHER_ACTION"}]
Expand All @@ -279,7 +279,7 @@ def test_given_valid_new_route_when_add_new_route_entry_and_mac_known_and_neighb
kwargs = {
"ifindex": 1,
"dst": "1.2.3.4",
"lladdr": "00:1a:2b:3c:4d:5e"
"lladdr": DEFAULT_MAC_ADDRESS
}
self.ndb.neighbours.dump.return_value = [kwargs]
mock_routes = [{"event": "RTM_NEWROUTE"}, {"event": "OTHER_ACTION"}]
Expand Down Expand Up @@ -481,13 +481,13 @@ def test_given_new_neighbor_in_unresolved_when_add_unresolved_new_neighbor_then_
kwargs = {
"ifindex": 1,
"dst": "192.168.1.1",
"lladdr": "00:1a:2b:3c:4d:5e"
"lladdr": DEFAULT_MAC_ADDRESS
}
self.ndb.neighbours.dump.return_value = [kwargs]
mock_netlink_msg = {
"attrs": {
"NDA_DST": "1.2.3.4",
"NDA_LLADDR": "00:1a:2b:3c:4d:5e",
"NDA_LLADDR": DEFAULT_MAC_ADDRESS ,
}
}
mock_routes = [{"event": "RTM_NEWROUTE"}, {"event": "OTHER_ACTION"}]
Expand Down
Loading
Loading