Delete 5 legacy hook scripts - #21
Merged
Merged
Conversation
…te.sh Removed: dirty-bit.sh, go-nil-return.sh, go-review.sh, go-vet-stop.sh, shell-compat.sh. All were consolidated in PR #16 but the files were kept. None are registered in hooks.json. Updated README architecture diagram to reference current hook names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove 5 dead hook scripts that were superseded by
lang-review.shandstop-gate.shin PR #16 but never cleaned up.Deleted files
dirty-bit.shstop-gate.sh(Phase 2)go-vet-stop.shstop-gate.sh(Phase 3)go-review.shlang-review.sh(Go section)go-nil-return.shlang-review.sh(Go nil-error detection)shell-compat.shlang-review.sh(Shell section)None were registered in
hooks.json. -433 lines of dead code.Also updated README architecture diagram to reference current hook names.
Test plan
validate-countspasses (hook count unchanged — these weren't registered)