Fix tri-* CLI fallbacks: capture stderr instead of swallowing - #23
Merged
Conversation
Change 2>/dev/null to 2>&1 across all 5 tri-* commands (review, dispatch, debug, security, test-gen) for both Codex and Gemini CLI fallbacks. This session both Codex and Gemini produced empty output because errors were silently discarded. With 2>&1, errors appear in the output file where the consolidation step can report them. Also added post-dispatch validation to tri-review: check for empty output files and warn instead of silently dropping agents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
2>/dev/nullto2>&1in all 5 tri-* commands for Codex and Gemini CLI fallbacks. Add post-dispatch empty-output validation to tri-review.Problem
This session, both Codex (empty output) and Gemini (keychain error) produced zero-byte output files because stderr was discarded. The consolidation step silently dropped both agents with no explanation.
Fix
2>&1captures errors in the output file instead of discarding themTest plan