Sync plugin.json version from git tag on build - #28
Merged
Conversation
Adds sync-version target to Makefile that writes the latest semver tag into plugin.json before compiling. Eliminates stale version on first Claude Code launch — the binary and plugin metadata now always agree.
- Fix broken fallback: use subshell so 0.0.0 actually fires when no tags - Warn instead of silent no-op when jq is missing or no tags found - Skip writing 0.0.0 to avoid downgrading real versions - Clean up .tmp file on jq/mv failure - Use order-only prerequisites to prevent parallel-make races
- Fail fast on malformed plugin.json instead of cascading to misleading error - Add semver format validation to reject non-semver git tags - Replace Unicode arrow with ASCII -> for CI/terminal portability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync-versionMakefile target that writes the latest semver git tag intoplugin.jsonbuildandinstalldepend onsync-versionso it runs automaticallyTest plan
make buildafter tagging a new version — verifyplugin.jsonupdatesmake buildwhen versions already match — verify no-op (no output)