Add domain probes, stub detection, and symptom triage - #33
Merged
Conversation
- references/domain-probes.md: domain-specific gray-area questions for feature brainstorming (auth, API, database, UI, etc.) - references/stub-patterns.md: mechanical grep patterns for detecting unfinished work (empty impls, placeholders, hardcoded values, skipped tests) - debug-checklists.md: symptom-to-category triage table for routing to the right domain checklist when the bug type isn't obvious - feature.md: reference domain probes in brainstorm step - self-audit.md: reference stub patterns in stale code section
stub-patterns.md:
- Add false-positive caveat for return nil/null/{}/[]
- Fix grep portability: use -E flag instead of \s for macOS compat
- Remove fragile Python except pipe pattern
- Add *.tsx/*.jsx to TODO, hardcoded-value, and catch-block patterns
- Add overall "matches require manual review" disclaimer
self-audit.md:
- Run stub detection unconditionally, not gated on TODO count
feature.md:
- Support multiple domains per feature (auth + API + UI)
- Skip probing when no domain section matches
debug-checklists.md:
- Merge duplicate Quick Symptom Lookup into Performance Bugs
checklist to eliminate DRY violation with Symptom Triage table
stub-patterns.md: - Split return-nothing grep by language (nil→Go, null/undefined→TS/JS, None→Python) - Fix pass$ regex to use word-boundary pattern (was matching bypass, overpass) - Add test_ prefix to Python test file exclusion self-audit.md: - Align inline TODO grep with stub-patterns.md canonical list (add tsx/jsx/rb/PLACEHOLDER) - Defer hardcoded secrets check to stub-patterns.md (was inconsistent: missing tsx, no test exclusion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
references/domain-probes.md) — 8 domain-specific question sets (auth, real-time, dashboard, API, database, UI, testing, deployment) for surfacing gray areas during/featurebrainstormingreferences/stub-patterns.md) — mechanical grep patterns for catching unfinished work: empty implementations, placeholder text, hardcoded values, skipped testsdebug-checklists.md) — symptom-first lookup that routes to the right domain checklist when the bug category isn't obviousInspired by patterns in gsd-build/get-shit-done, adapted to devkit's composable reference-file approach. No new commands — supplements existing workflows via selective reference loading.
Test plan
/featurewith an auth-related request — verify domain probes surface relevant questions/self-auditon a repo with TODOs — verify stub patterns reference appears in stale code analysis/tri-debugwith an ambiguous symptom — verify triage table helps route to correct checklist