Add ERR trap logging and migrate to [[ ]] in stop-gate.sh - #36
Merged
Conversation
- ERR trap now logs to stderr before approving, so broken quality gates are visible in debug output instead of silently passing. - All test brackets migrated from [ ] to [[ ]] per shell.md rules. Bash-specific [[ ]] is safer with unquoted variables and glob patterns.
Tri-review consensus (3/3 agents): one [ -n "$TS_FILES" ] was not converted to [[ ]]. Now all brackets in stop-gate.sh use [[ ]].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stop-gate: ERR trap fired — approving to avoid hangto stderr before approving. Users can now see when the quality gate is broken.[ ]→[[ ]]: Migrated all 17 test brackets from POSIX[ ]to bash[[ ]]per.claude/rules/shell.md. Safer with unquoted variables and glob patterns.Why
These were flagged as pre-existing issues during the tri-review and pr-review-toolkit review of PR #35, but out of scope for that diff. Cleaning them up separately.
Test plan
bash -n hooks/stop-gate.sh— syntax validgrep '^\s+\[ ' hooks/stop-gate.sh— no remaining[ ]brackets