fix(workflows): tri-review + tri-security enforce: soft - #70
Merged
Conversation
The gather step is a prompt that collects the diff/code to review — it needs Bash to run git diff. Under the default hard enforce added in v2.1.8, that tool is blocked on prompt steps, so tri-review cannot start. Mark the workflow enforce: soft; other analytical steps (review-smart/general/fast, consolidate) still work because soft only downgrades to a stderr nudge and the Stop gate still requires devkit_advance.
5uck1ess
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflows/tri-review.ymlandworkflows/tri-security.ymlboth gainenforce: softat workflow level so theirgatherprompt steps can rungit diff/ similar Bash commands without being blocked by the v2.1.8+ prompt-hard guard.Why
Under default hard enforce, prompt steps block
Bash/Edit/Write/Task/WebFetchto prevent drift (#63/#64). Both tri-review and tri-security start with agatherprompt that asks the agent to "collect the code/diff to review" from{{input}}, which the agent typically resolves by runninggit difforgh pr diff. That's blocked under hard.tri-debugandtri-dispatchare unaffected — they take{{input}}directly into the diagnosis/dispatch prompts and only needRead/Grep, which are already allowed on hard.What this costs
Drift protection is weakened for the other prompt steps in both workflows (
review-*,audit-*,consolidate). Those are purely analytical — they read prior-step outputs and produce text, not writes — but they're now allowed to use any tool. The Stop gate still requiresdevkit_advancebetween steps, so the agent can't skip steps, it just isn't blocked from using tools during a step.Test plan
go test ./engine/... -run ParseWorkflow— both YAMLs still parse/devkit:tri-reviewand/devkit:tri-securityagainst a PR after next plugin upgrade; confirmgathercompletes without a guard veto