fix: populate agent bodies, sync mcpb version, update layout docs - #86
Merged
Conversation
… layout docs Agents were frontmatter-only stubs — missing `description:` and empty bodies, so Claude Code's loader had nothing to dispatch by. Add a description + system-prompt body to all six subagents (documenter, improver, researcher, reviewer, security-auditor, test-writer) so the Task-tool invocations from workflows (doc-gen, test-gen, onboard, pr-ready, tri-review, etc.) resolve against real agent definitions. Extend `make sync-version` to also rewrite `mcpb/manifest.json` so the bundled MCP server descriptor no longer drifts from `.claude-plugin/plugin.json` on every release, and bump the file to 2.1.19 to match main. Fix CLAUDE.md layout table drift caught by the validator: 39 → 38 skills, and replace the "commands/ mostly empty" row with the real contents (`commands/references/` has debug-checklists, domain-probes, stub-patterns). Update `hooks/hooks_test.sh` header comment from "10 registered hooks" to the actual 12 tested scripts.
The mcpb-bundle-integrity CI check re-hashes every tracked source against the sidecar, and the manifest.json version change in 884e0b1 invalidated its pinned sha256. Rebuild via bin/mcpb-build so the sidecar, the zipped bundle, and the cross-compiled Windows launcher all line up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the
plugin-validatorfindings from the devkit self-evaluation.Critical fixes:
agents/*.md). All six were frontmatter-only stubs with nodescription:field, so Claude Code's loader had nothing to dispatch by — even though workflows likedoc-gen,test-gen,onboard,pr-ready, andtri-reviewinvoke them by name via the Task tool. Addeddescription:+ a concise system prompt todocumenter,improver,researcher,reviewer,security-auditor, andtest-writer.mcpb/manifest.jsonversion drift. Was stuck at0.0.0while.claude-plugin/plugin.jsonis2.1.19. Extendedmake sync-versionto rewrite both files in the same loop, and bumpedmcpb/manifest.jsonto match current main.CLAUDE.md + hook-comment drift:
commands/was "mostly empty since PR refactor(plugin): migrate commands/ to skills/ #77" — it actually holdscommands/references/withdebug-checklists.md,domain-probes.md,stub-patterns.md.hooks/hooks_test.shheader comment said "all 10 registered hooks"; the suite exercises 12 distinct scripts. Updated.Test plan
bash hooks/hooks_test.sh— 70 passed, 0 failedmake -C src test— all Go tests passmake -C src sync-version— runs clean on both files, no-op when already in syncdoc-gen/test-genrun in a fresh session to confirm the populated agents load and dispatch