Repository navigation
fix(prompts): 精简聊天表达并恢复分条习惯（v3.18.7） - #112
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update reply guidance and examples res/prompts/undefined.xml, res/prompts/undefined_nagaagent.xml, res/IMPORTANT/each.md, docs/usage.md, tests/test_prompt_structure.py, CHANGELOG.md |
Both prompts and related guidance describe brief everyday replies, separate delivery of independent ideas, and QQ spacing and punctuation preferences. Formal content, complete tasks, and user-requested formats retain their requirements. A parameterized test checks that selected guidance appears once and matches across both prompt variants. |
Update release metadata apps/undefined-chat/{package.json,src-tauri/Cargo.toml,src-tauri/tauri.conf.json}, apps/undefined-console/{package.json,src-tauri/Cargo.toml,src-tauri/tauri.conf.json}, pyproject.toml, src/Undefined/__init__.py |
Project, package, and application version fields change from 3.18.6 to 3.18.7. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Bug fix
Merge Risk: 
078fe
-
The reply-style and version updates appear mergeable after normal checks. Actual conversational tone can be evaluated in use.
Pre-merge checks: 
-
Check name Status Explanation Title check The title is in Chinese and reads: "fix(prompts): tighten chat expression and restore per-message splitting (v3.18.7)". It names the main change: the default reply style is made shorter and more collo… Description check The description follows the template well. It has a change summary (变更说明) explaining the default expression change and why it is needed. It has an impact scope (影响范围) listing the prompts, reminders, e… Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (12 skipped: 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title is in Chinese and reads: "fix(prompts): tighten chat expression and restore per-message splitting (v3.18.7)". It names the main change: the default reply style is made shorter and more colloquial, and the prompt rules for splitting independent ideas into separate messages, fewer blank lines on QQ, and omitting periods in short replies are restored. It matches the changeset, which edits the two main prompt files, the reminder text, the examples, and adds a consistency test. The version tag in parentheses is extra detail but does not make the title misleading.
Full details: Description check
-
Explanation
The description follows the template well. It has a change summary (变更说明) explaining the default expression change and why it is needed. It has an impact scope (影响范围) listing the prompts, reminders, examples, consistency test, and version bump. It has a self-check list with results, and it has a remarks section noting that real-model tone still needs live chat testing. The related-issue section is filled in as 无 (none), which is valid. Ruff, mypy, and pytest are all marked as checked. The template's Chinese headings and structure are kept. The WebUI/Tauri screenshot item is unchecked, but the PR does not change those interfaces, so this does not block merge. The 'Closes/Refs' line is explicitly marked none. Overall the description is complete.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (12 skipped: 12 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
变更说明
日常回复缺少明确的篇幅、分条与标点偏好，容易扩成长段说明。本 PR 将默认表达调整为简短口语，恢复独立意思分消息、QQ 少空行和日常短答省句号的规则；正式长文、完整步骤、代码与用户指定格式仍保留所需细节和结构。
影响范围
3.18.7，同步 Python、Console、Chat 的版本与锁文件，并补充主题化 changelog。关联 Issue
无。
自检
uv run pytest tests/ --cov --cov-report=term：4591 passed、2 skipped，覆盖率 70.27%，达到 65% 门槛。npm --prefix apps/undefined-console run check通过。npm --prefix apps/undefined-chat run check通过，包含 507 项单元测试、50 项端到端测试、生产构建回归及 76 项 Rust 测试。uv run python scripts/release_notes.py validate --tag v3.18.7通过。uv build --wheel通过，wheel 内的两套主提示词、每轮提醒与 changelog 均与源码一致。git diff --check与两个提交的 GPG 签名验证通过。备注
当前验证覆盖提示词规则、组装、版本一致性与打包；实际模型的语气效果尚需实聊验证。
Summary by CodeRabbit