1.9.4-1.19.3 support - #42
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThe project adds Minecraft version configurations from 1.9.4 through 26.2, Java compatibility settings, legacy runtime branches, dynamic artifact publishing, and updated documentation and metadata. ChangesMinecraft version support
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Maintainer
participant ReleaseWorkflow
participant GradleBuild
participant GitHubRelease
participant README
Maintainer->>ReleaseWorkflow: provide release and snapshot versions
ReleaseWorkflow->>GradleBuild: build versioned artifacts
GradleBuild-->>ReleaseWorkflow: return versioned JARs
ReleaseWorkflow->>GitHubRelease: create release with discovered JARs
ReleaseWorkflow->>README: update version and download tables
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 137-146: Update the release step around the ASSETS array to
validate that at least one jar was discovered before invoking gh release create.
If ASSETS is empty, print an appropriate error and exit with a nonzero status;
otherwise preserve the existing release creation flow and asset arguments.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bebbfcbc-e36f-4e35-81f8-d08664843c27
📒 Files selected for processing (3)
.github/workflows/build.yml.github/workflows/release.ymlREADME.md
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 148-150: Update the “Update README download links” step and the
release step near the referenced location to pass inputs.version through the
step’s environment rather than interpolating it inside Bash source; have the
scripts read the environment variable while preserving the existing version
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 89ef17e9-7cb5-4f74-9a34-fb65563df6cb
📒 Files selected for processing (2)
.github/workflows/release.ymlREADME.md
🚧 Files skipped from review as they are similar to previous changes (1)
- README.md
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
32-32: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMake the Java requirement explicit for each version.
Specify Java 17 for 1.20–1.20.4 and Java 21 for 1.20.5–1.20.6 instead of listing
17/21for the full range.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 32, Update the README version compatibility table to state Java 17 specifically for versions 1.20 through 1.20.4 and Java 21 specifically for versions 1.20.5 and 1.20.6, replacing the ambiguous combined “17/21” requirement.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.md`:
- Line 32: Update the README version compatibility table to state Java 17
specifically for versions 1.20 through 1.20.4 and Java 21 specifically for
versions 1.20.5 and 1.20.6, replacing the ambiguous combined “17/21”
requirement.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8107bd6f-6a29-408b-b3a9-fb2ea4b657f8
📒 Files selected for processing (13)
README.mdsettings.gradle.ktssrc/main/java/net/blockhost/anarchymod/JoinPayload.javasrc/main/java/net/blockhost/anarchymod/mixin/ClientPacketListenerMixin.javasrc/main/java/net/blockhost/anarchymod/mixin/ServerListMixin.javasrc/test/java/net/blockhost/anarchymod/JoinPayloadTest.javaversions/1.10.2/gradle.propertiesversions/1.11.2/gradle.propertiesversions/1.12.2/gradle.propertiesversions/1.13.2/gradle.propertiesversions/1.14.3/gradle.propertiesversions/1.9.4/gradle.propertiesyarn-build.gradle.kts
thororen1234
force-pushed
the
1.14.4-1.19.3
branch
from
August 2, 2026 19:34
978dc96 to
1cba0c6
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
95-118: 📐 Maintainability & Code Quality | 🔵 TrivialExtract the duplicated version-table generation logic.
The
link(),join(),mapfile MC_VERSIONS, and per-minor-version grouping loop in the "Create GitHub Release" step (lines 95-118) are duplicated almost verbatim in the "Update README download links" step (lines 159-187), with only the grouped output format differing (release notes rows versus README rows with Java version). Extract this into a shared script (for examplescripts/generate-version-table.sh) parameterized by output format, and call it from both steps.Also applies to: 159-187
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/build.yml around lines 95 - 118, Extract the shared version-table logic—including link/join helpers, MC_VERSIONS loading, and minor-version grouping—from the Create GitHub Release and Update README download links steps into a reusable script such as scripts/generate-version-table.sh. Parameterize that script for the differing release-note and README row formats, then update both workflow steps to invoke it while preserving their existing outputs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build.yml:
- Around line 83-92: Update the “Create GitHub Release” step to pass
inputs.version through its env configuration and assign VERSION from the shell
environment, matching the safe pattern used by the later step; remove the direct
${{ inputs.version }} interpolation from the run script while preserving the
existing release URL and link behavior.
- Around line 1-18: Add job-level permissions granting contents: write to the
set-release-version reusable-workflow job and the set-after-version job. Ensure
both callers provide this permission without adding a top-level workflow
permission.
In `@versions/1.16.4/gradle.properties`:
- Around line 1-5: Correct the version metadata in
versions/1.16.4/gradle.properties lines 1-5 by setting minecraft_version to
1.16.4 and removing yarn_group and yarn_mappings; update
versions/1.16.5/gradle.properties lines 1-3 to set minecraft_version to 1.16.5,
leaving its other properties unchanged.
---
Nitpick comments:
In @.github/workflows/build.yml:
- Around line 95-118: Extract the shared version-table logic—including link/join
helpers, MC_VERSIONS loading, and minor-version grouping—from the Create GitHub
Release and Update README download links steps into a reusable script such as
scripts/generate-version-table.sh. Parameterize that script for the differing
release-note and README row formats, then update both workflow steps to invoke
it while preserving their existing outputs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 30747a27-2b7a-45e1-a375-e5ad93fb696d
📒 Files selected for processing (64)
.github/workflows/build.yml.github/workflows/release.yml.gitignoreREADME.md_config.ymlbuild.gradle.ktssettings.gradle.ktssrc/main/java/net/blockhost/anarchymod/Domains.javasrc/main/java/net/blockhost/anarchymod/JoinPayload.javasrc/main/java/net/blockhost/anarchymod/mixin/BlockedServersMixin.javasrc/main/java/net/blockhost/anarchymod/mixin/ClientPacketListenerMixin.javasrc/main/java/net/blockhost/anarchymod/mixin/ServerListMixin.javasrc/main/resources/fabric.mod.jsonsrc/test/java/net/blockhost/anarchymod/JoinPayloadTest.javaversions/1.10.2/gradle.propertiesversions/1.11.2/gradle.propertiesversions/1.12.2/gradle.propertiesversions/1.13.2/gradle.propertiesversions/1.14.3/gradle.propertiesversions/1.14.4/gradle.propertiesversions/1.15.1/gradle.propertiesversions/1.15.2/gradle.propertiesversions/1.15/gradle.propertiesversions/1.16.1/gradle.propertiesversions/1.16.2/gradle.propertiesversions/1.16.3/gradle.propertiesversions/1.16.4/gradle.propertiesversions/1.16.5/gradle.propertiesversions/1.16/gradle.propertiesversions/1.17.1/gradle.propertiesversions/1.17/gradle.propertiesversions/1.18.1/gradle.propertiesversions/1.18.2/gradle.propertiesversions/1.18/gradle.propertiesversions/1.19.1/gradle.propertiesversions/1.19.2/gradle.propertiesversions/1.19.3/gradle.propertiesversions/1.19.4/gradle.propertiesversions/1.19/gradle.propertiesversions/1.20.1/gradle.propertiesversions/1.20.2/gradle.propertiesversions/1.20.3/gradle.propertiesversions/1.20.4/gradle.propertiesversions/1.20.5/gradle.propertiesversions/1.20.6/gradle.propertiesversions/1.20/gradle.propertiesversions/1.21.1/gradle.propertiesversions/1.21.10/gradle.propertiesversions/1.21.11/gradle.propertiesversions/1.21.2/gradle.propertiesversions/1.21.3/gradle.propertiesversions/1.21.4/gradle.propertiesversions/1.21.5/gradle.propertiesversions/1.21.6/gradle.propertiesversions/1.21.7/gradle.propertiesversions/1.21.8/gradle.propertiesversions/1.21.9/gradle.propertiesversions/1.21/gradle.propertiesversions/1.9.4/gradle.propertiesversions/26.1.1/gradle.propertiesversions/26.1.2/gradle.propertiesversions/26.1/gradle.propertiesversions/26.2/gradle.propertiesyarn-build.gradle.kts
🚧 Files skipped from review as they are similar to previous changes (61)
- versions/1.15.2/gradle.properties
- versions/26.1.1/gradle.properties
- versions/26.1/gradle.properties
- versions/1.21.1/gradle.properties
- versions/1.17/gradle.properties
- versions/1.21.7/gradle.properties
- versions/1.14.4/gradle.properties
- versions/1.21.10/gradle.properties
- versions/1.21.6/gradle.properties
- versions/1.20.2/gradle.properties
- versions/1.12.2/gradle.properties
- README.md
- versions/1.16.3/gradle.properties
- versions/1.16.2/gradle.properties
- src/test/java/net/blockhost/anarchymod/JoinPayloadTest.java
- versions/1.19.4/gradle.properties
- versions/1.21.9/gradle.properties
- versions/1.18.1/gradle.properties
- versions/1.20.5/gradle.properties
- versions/1.18.2/gradle.properties
- versions/1.21.8/gradle.properties
- _config.yml
- versions/1.10.2/gradle.properties
- versions/1.13.2/gradle.properties
- versions/1.21.5/gradle.properties
- versions/1.21.2/gradle.properties
- versions/1.16.1/gradle.properties
- versions/1.18/gradle.properties
- versions/1.19.2/gradle.properties
- versions/1.20.1/gradle.properties
- versions/1.15/gradle.properties
- versions/1.21.11/gradle.properties
- versions/26.1.2/gradle.properties
- versions/1.19.3/gradle.properties
- versions/1.16/gradle.properties
- versions/1.21/gradle.properties
- versions/1.20.4/gradle.properties
- versions/1.19/gradle.properties
- versions/1.9.4/gradle.properties
- build.gradle.kts
- src/main/java/net/blockhost/anarchymod/mixin/BlockedServersMixin.java
- versions/1.20/gradle.properties
- versions/1.11.2/gradle.properties
- versions/1.19.1/gradle.properties
- .gitignore
- versions/1.21.4/gradle.properties
- src/main/resources/fabric.mod.json
- versions/1.14.3/gradle.properties
- src/main/java/net/blockhost/anarchymod/Domains.java
- .github/workflows/release.yml
- src/main/java/net/blockhost/anarchymod/mixin/ClientPacketListenerMixin.java
- yarn-build.gradle.kts
- versions/1.21.3/gradle.properties
- settings.gradle.kts
- versions/1.20.3/gradle.properties
- src/main/java/net/blockhost/anarchymod/JoinPayload.java
- versions/1.17.1/gradle.properties
- versions/1.15.1/gradle.properties
- versions/1.20.6/gradle.properties
- versions/26.2/gradle.properties
- src/main/java/net/blockhost/anarchymod/mixin/ServerListMixin.java
Member
|
@coderabbitai review |
✅ Action performedReview finished.
|
AlexProgrammerDE
approved these changes
Aug 3, 2026
AlexProgrammerDE
left a comment
AlexProgrammerDE
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes are as follows:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation