Skip to content

feat(notify): add durable explicit notification journal - #156

Draft
777genius wants to merge 2 commits into
feat/agent-notify-native-protocolfrom
feat/agent-notify-journal
Draft

777genius wants to merge 2 commits into
feat/agent-notify-native-protocolfrom
feat/agent-notify-journal

Conversation

@777genius

Copy link
Copy Markdown
Owner

Adds the durable admission journal for agent-triggered notifications. Requests are scoped by source, session and key kind; an admission is persisted before delivery, and ambiguous outcomes remain replayable without granting another effect.

The package provides bounded snapshots, permanent kernel locking, conservative seven-day retention, atomic rate limits, attempt-token finalization and read-only lookup. Service/CLI wiring is the next integration step.

Stacked on #153 (feat/agent-notify-native-protocol). This is the journal portion of phase 4, prepared independently under the plan's parallel-work allowance. The 2,075 added lines keep the persistence invariant and its process/crash tests together; 1,007 lines are tests.

Validation:

  • Independent source review: no actionable findings; source hashes verified before and after review.
  • Linux focused tests, vet and race tests passed; Windows unsupported-platform path compiles.
  • macOS package tests passed, including real child-process crash/concurrency fixtures; the Darwin kernel clock qualification passed separately.
  • These checks cover journal behavior. Native delivery, installed Desktop E2E and release qualification remain separate gates.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant