Skip to content

feat(notify): add explicit notification service and durable outcomes - #159

Draft
777genius wants to merge 3 commits into
feat/agent-notify-configurable-ratesfrom
feat/agent-notify-service
Draft

777genius wants to merge 3 commits into
feat/agent-notify-configurable-ratesfrom
feat/agent-notify-service

Conversation

@777genius

Copy link
Copy Markdown
Owner

Adds the explicit notification service behind injected policy, origin, readiness and delivery ports. A request is durably admitted before delivery; replays preserve the original target and the actual terminal navigation/suppression outcome without resending. Configurable limits use the shared journal transaction.

Stacked on #158. This is the service checkpoint; CLI/MCP activation and installed Desktop qualification remain later steps.

Validation: exact-source independent follow-up review found no actionable issues; focused Linux unit/race/vet passed as a non-root user; Mac service/journal/origin suites passed. The combined real SDK -> service -> journal fixture also passes with mocked OS delivery. No installed notification or release claim.

The coherent patch is 2,187 changed lines, slightly above the review target; most additions are regression tests for the single admission/outcome invariant. Splitting terminal persistence from service validation would leave an inconsistent intermediate contract. Old writers must be fenced before activation; journal history is never reset.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant