Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the explicit notification service behind injected policy, origin, readiness and delivery ports. A request is durably admitted before delivery; replays preserve the original target and the actual terminal navigation/suppression outcome without resending. Configurable limits use the shared journal transaction.
Stacked on #158. This is the service checkpoint; CLI/MCP activation and installed Desktop qualification remain later steps.
Validation: exact-source independent follow-up review found no actionable issues; focused Linux unit/race/vet passed as a non-root user; Mac service/journal/origin suites passed. The combined real SDK -> service -> journal fixture also passes with mocked OS delivery. No installed notification or release claim.
The coherent patch is 2,187 changed lines, slightly above the review target; most additions are regression tests for the single admission/outcome invariant. Splitting terminal persistence from service validation would leave an inconsistent intermediate contract. Old writers must be fenced before activation; journal history is never reset.