Conversation
…riter publication Tests were asserting POSIX modes, copy-only install.sh, and an uncoordinated MCP clock that the kernel no longer matches; they now expect platform-true permissions, launcher refresh, protocol-compliant publication, and a handshake-armed deadline. Co-authored-by: Илия <iliyazelenkog@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Landed on feat/agent-notify-e2e for PR 177; closing the nested PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 6 P2 findings from PR 177 review on
d5f13af. These are test/fixture defects only; production admission,service.go, writer protocol floor, and product-identity-as-destination are unchanged.--removenow asserts the owned skill is absent and consumers are empty (Unix shared-retention half unchanged).0666(identityMode).internal-install-runtime --refreshpublishes both BAT launcher aliases with productionWindowsLauncherScriptbytes; refresh still fails if launchers are missing.bin/install.shplus isolated seams (staged/local assets, no network, no desktop integrations) so setup-codex commits a protocol-compliant writer.now.Store(100)only aftersynctest.Wait()so initialize/initialized and the deadline watcher cannot consume the capture budget.ERROR_SHARING_VIOLATION/ Access is denied for the fixture WriteFile+Rename only.Test plan
go test ./internal/config/ -count=1 -run TestPreparego test ./internal/installruntime/ -count=1 -run TestSetupSnapshotPreimageIsBoundToParsedBytesgo test ./internal/agentnotify/mcp/ -count=1 -run TestSDKOriginalDeadlineExpiredBeforeHandlergo test ./cmd/claude-notifications/ -count=1 -run TestEmbeddedSkillLifecycleProjectiontest_windows_native_hooks_configured_existing_binaryfrombin/install_e2e_test.shscripts/config_e2e_test.py16/16 with isolated helper binaryfeat/agent-notify-e2e(Windows 1.25/1.26, Ubuntu, macOS E2E)