Conversation
Auto-default skips agent-notify MCP on unsupported OS or an old CLI and keeps hooks-only success. Explicit --agent-notify and a failed configure of a supported capability now return incomplete/nonzero without rolling back committed hooks. Co-authored-by: Илия <iliyazelenkog@gmail.com>
Linux is a supported agent-notify configure OS after the production session-bus and navigation-none installer. Auto-default now calls configure instead of skipping as unsupported_platform; explicit --agent-notify no longer fails as an unsupported OS. Co-authored-by: Илия <iliyazelenkog@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
install_codex only passes --skip-agent-notify when the published CLI help lists it. The inert test helper now prints that flag so Linux auto MCP configure stays on the later bootstrap step, not setup-codex. Co-authored-by: Илия <iliyazelenkog@gmail.com>
Co-authored-by: Илия <iliyazelenkog@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cursor/uap-installer-linux-clock-6c84 #188 +/- ##
=========================================================================
- Coverage 65.30% 65.08% -0.22%
=========================================================================
Files 170 170
Lines 17333 17349 +16
=========================================================================
- Hits 11319 11292 -27
- Misses 4388 4432 +44
+ Partials 1626 1625 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Linux auto-default now runs setup-notifications configure. The config suite's mock Claude/Codex CLIs are not a valid MCP inventory, so bootstrap failed closed with inventory_unknown. Keep this suite on --skip-agent-notify; real MCP configure is covered by setup-codex e2e. Co-authored-by: Илия <iliyazelenkog@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #186. After Linux production D-Bus delivery and navigation-none installer, R0 auto/explicit
--agent-notifymust treat Linux as a supported MCP configure OS.This does not fold Linux into #185 (macOS-only capability gate on
#177) or into the Windows configure child of #187.What changed
agent_notify_platform_supported/agentNotifySetupSupported()accept Darwin or Linux./initcall configure on Linux (navigation=none).--agent-notifyon Linux is a real configure attempt.Tests
go test ./cmd/claude-notifications -count=1 -timeout 180s -run 'TestNotificationBootstrap|TestSetupCodexE2EConfigureNotifications'go test ./internal/notifier -count=1 -race -run TestFreedesktopSessionBusSubmit