docs(cla): accept the CLA by opening a pull request - #194
Conversation
Stop requiring a signatures-table row. After this CLA is on main, opening a PR or pushing commits to one is acceptance.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe CLA now records acceptance through pull request or commit submission after publication on the default branch. The signature table and related instructions are removed. Contributor guidance and the pull request template reflect the new process. ChangesCLA acceptance
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit opens a pull request bright Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1223e71f69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - GitHub login | ||
| - date (`YYYY-MM-DD`) | ||
| Each person who authors a commit in the pull request accepts this Agreement for their Contribution. Do not include another person's work unless they agree to this CLA. |
There was a problem hiding this comment.
Require each commit author to accept personally
When a maintainer or PR owner pushes a cherry-picked, co-authored, or otherwise third-party commit, only the pusher has performed the acceptance action defined on line 93; the commit author may never have seen this agreement or Submitted anything after its publication. Treating authorship itself as acceptance therefore leaves that author's work without the intended additional license grant. Require an affirmative action from every human author rather than inferring acceptance from commit metadata.
Useful? React with 👍 / 👎.
| ## 6. How to accept | ||
|
|
||
| You accept this CLA only by adding a row to the **CLA signatures** table in a pull request from the GitHub account listed in that row, and having that change merged. A checklist box in a pull request template is not enough by itself. | ||
| You accept this CLA by Submitting a Contribution after this version is published on the default branch. That includes opening a pull request or pushing commits onto a pull request. Do not Submit if you do not agree. |
There was a problem hiding this comment.
Add an acceptance path for already-open pull requests
For a pull request opened before this version reaches the default branch and receiving no later push, this clause correctly says no acceptance occurred, but the change removes both the signatures table and the maintainer instruction that previously blocked such a merge. The updated template is not retroactively added to existing PRs, so those PRs can now be merged without any documented way to obtain the extra grant; require an explicit acceptance comment, reopen, or post-publication push for outstanding PRs.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 65.87% 65.83% -0.04%
==========================================
Files 87 87
Lines 8653 8653
==========================================
- Hits 5700 5697 -3
- Misses 2429 2431 +2
- Partials 524 525 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Test plan
.github/CLA.mdsection 6: no table required.Made with Cursor
Summary by CodeRabbit