Skip to content

docs(cla): accept the CLA by opening a pull request - #194

Merged
777genius merged 1 commit into
mainfrom
docs/cla-accept-by-pr
Sep 16, 2026
Merged

777genius merged 1 commit into
mainfrom
docs/cla-accept-by-pr

Conversation

@777genius

@777genius 777genius commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Opening a pull request (or pushing commits to one) is acceptance of the CLA. Contributors do not add a signatures-table row.
  • Public outbound license stays GPL-3.0-or-later.

Test plan

  • Read .github/CLA.md section 6: no table required.
  • New PR form shows the agree-by-opening checkbox.

Made with Cursor

Summary by CodeRabbit

  • Documentation
    • Updated the Contributor License Agreement to define acceptance through contributions, such as opening a pull request or pushing commits.
    • Removed signature-table requirements and related instructions.
    • Updated contributor guidance to explain licensing, sublicensing, employer-owned work, and co-authored commits.
    • Revised the pull request template and README to reflect the updated acceptance process and clarify that contributors should not add signature-table entries.

Stop requiring a signatures-table row. After this CLA is on main,
opening a PR or pushing commits to one is acceptance.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T08:14:54.015545Z 1223e71 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 211cbde6-bd80-4bf9-9530-a67ffb22da0e

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd4532 and 1223e71.

📒 Files selected for processing (4)
  • .github/CLA.md
  • .github/pull_request_template.md
  • CONTRIBUTING.md
  • README.md

📝 Walkthrough

Walkthrough

The CLA now records acceptance through pull request or commit submission after publication on the default branch. The signature table and related instructions are removed. Contributor guidance and the pull request template reflect the new process.

Changes

CLA acceptance

Layer / File(s) Summary
CLA acceptance contract
.github/CLA.md
The CLA defines acceptance through Contributions, updates the effective date and contributor representations, and removes the signature-table process.
Contributor workflow guidance
.github/pull_request_template.md, CONTRIBUTING.md, README.md
The template and project documentation describe submission-based acceptance, employer-owned work, co-authored commits, and the additional sublicensing grant.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/cla-accept-by-pr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit opens a pull request bright
The old signature table leaves sight
Each commit speaks its author’s name
The CLA follows the submission game
Clear guidance now marks the way

Comment @coderabbitai help to get the list of available commands.

@777genius
777genius merged commit cfd9633 into main Sep 16, 2026
8 of 9 checks passed
@777genius
777genius deleted the docs/cla-accept-by-pr branch September 16, 2026 08:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1223e71f69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/CLA.md
- GitHub login
- email
- date (`YYYY-MM-DD`)
Each person who authors a commit in the pull request accepts this Agreement for their Contribution. Do not include another person's work unless they agree to this CLA.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require each commit author to accept personally

When a maintainer or PR owner pushes a cherry-picked, co-authored, or otherwise third-party commit, only the pusher has performed the acceptance action defined on line 93; the commit author may never have seen this agreement or Submitted anything after its publication. Treating authorship itself as acceptance therefore leaves that author's work without the intended additional license grant. Require an affirmative action from every human author rather than inferring acceptance from commit metadata.

Useful? React with 👍 / 👎.

Comment thread .github/CLA.md
## 6. How to accept

You accept this CLA only by adding a row to the **CLA signatures** table in a pull request from the GitHub account listed in that row, and having that change merged. A checklist box in a pull request template is not enough by itself.
You accept this CLA by Submitting a Contribution after this version is published on the default branch. That includes opening a pull request or pushing commits onto a pull request. Do not Submit if you do not agree.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add an acceptance path for already-open pull requests

For a pull request opened before this version reaches the default branch and receiving no later push, this clause correctly says no acceptance occurred, but the change removes both the signatures table and the maintainer instruction that previously blocked such a merge. The updated template is not retroactively added to existing PRs, so those PRs can now be merged without any documented way to obtain the extra grant; require an explicit acceptance comment, reopen, or post-publication push for outstanding PRs.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.83%. Comparing base (5fd4532) to head (1223e71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   65.87%   65.83%   -0.04%     
==========================================
  Files          87       87              
  Lines        8653     8653              
==========================================
- Hits         5700     5697       -3     
- Misses       2429     2431       +2     
- Partials      524      525       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant