refactor(agentplugins): close the client adapter contract (Part 11)

[777genius]

Summary

• Drop transitional aliases (providers.CommandRunner, providers.ManagedMarketplaceName, Planner.Detected) so PlanRequest.Detected is the only detection surface.
• Clear the ClientID-selector budget outside domain/clients.go, clients/<id>, and clients/all; catalog/directory ChatGPT policy now uses PlansWithoutHostPresence / AppSupport.
• Record the adapter contract in ADR 0007, add test-only clients/internal/exampleclient plus the contracttest README, and split in-scope files out of the LEGACY SIZE BASELINE.

Grok 4.6 review: Approve with nits (docs rule name, exampleclient import checks, leftover gocyclo 20). Cheap nits folded here. Do not merge to main.

Test plan

• go test archtest, exampleclient, catalog, directoryv1, usecase, planner, providers, clients/all, agentpluginscli (hooks disabled), cmd/agentplugins
• size gate on split packages; --new-from-merge-base vs architecture for install/integrationctl and cli/plugin-kit-ai
• check-lint-baseline.sh shrink-only (165 → 139 exclusion rules)
• core-fast on this PR
• squash-merge into refactor/installer-core-clean-architecture after green; never merge refactor: installer core clean architecture refactor #288 to main

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 04c6954e-dcf3-46e0-9170-545bc10b7d77

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}