Task_2_1_2#17
Merged
Merged
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
|
|
|
|
|
|
galinabykova
requested changes
Apr 30, 2026
| ConnectionHandler handler = new ConnectionHandler(socket, array, | ||
| queue, primeFound, activeWorkers, | ||
| workerName); | ||
| new Thread(handler).start(); |
Collaborator
There was a problem hiding this comment.
ты создаёшь отдельный поток для каждого подключения. Какие есть проблемы у такого подхода? Какие альтернативы?
Owner
Author
There was a problem hiding this comment.
я подумал, что эффективнее сделать тред пул здесь. в задачах учебных не столь принципиально, наверное, но вот при масштабируемости выигрыш получим значительный (thread per task проигрывает в производительности)
Collaborator
There was a problem hiding this comment.
к сожалению, тредпул тут не будет работать, потому что он выполняет задачу до конца и только потом берёт следующую. Получается, что к твоему серверу сможет получиться только N воркеров, где N - число потоков в тредпуле(
Owner
Author
There was a problem hiding this comment.
мисконцепт вышел.. при использовании FixedThreadPool ограничевается количество воркеров N. если все потоки заняты обслуживанием соединений, то новые воркеры не смогут начать работу, пока кто-то не отключится. как альтернатива java nio или виртуальные потоки
|
|
|
|
|
galinabykova
requested changes
May 4, 2026
galinabykova
requested changes
May 4, 2026
Collaborator
galinabykova
left a comment
galinabykova
left a comment
There was a problem hiding this comment.
оставила комментарий в прошлом обсуждении)
galinabykova
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.