Fix ephemeral scheduler pytest fixture cleanup - #83
Merged
Conversation
8Dionysus
force-pushed
the
fix/pytest-scheduler-ephemeral-basetemp-20260906
branch
from
September 6, 2026 04:49
463d598 to
547b2d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ephemeral scheduler trials put pytest's
tmp_pathandtmpdirfixtures under the shared host temporary root because the child pytest commands did not set--basetemp. The outerTemporaryDirectorythen removed only the job artifact root, leaving fixture generations behind inpytest-of-*.Change
Bind each scheduler pytest process to a private basetemp under its job artifact root:
pytest-basetemp/collectionpytest-basetemp/shard-Npytest-basetemp/pytestxdist continues to create
popen-gwNworker directories beneath the per-process root. Explicit artifact and receipt runs retain the artifact tree; ephemeral runs reclaim it through the existingTemporaryDirectoryowner.Validation
PYTHONDONTWRITEBYTECODE=1 python3 -m pytest -q -p no:cacheprovider tests/test_validation_scheduler_experiment.py(18 passed)ruff check scripts/pytest_scheduler_experiment.py tests/test_validation_scheduler_experiment.pypython3 -m py_compile scripts/pytest_scheduler_experiment.py tests/test_validation_scheduler_experiment.pygit diff --checkNo full scheduler corpus run was needed for this focused lifecycle change.