Quote rc commands if necessary #136
Open
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptaffe
force-pushed
the
feat/escape-rc-commands
branch
from
94e159c to
db16dce
Compare
Surround an argument with quotes before assembling it into a command base on whether a command requires quoting to be parsed by rc as it was received through args. If the arg contains any of rc's special characters or whitespace as documented in rc(1), it is quoted and any ' characters are escaped to ''. The quoted command string is also appended to the dump command. Fixes 9fans#135
cptaffe
force-pushed
the
feat/escape-rc-commands
branch
from
db16dce to
716bfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surround an argument with quotes before assembling it into a command base on whether a command requires quoting to be parsed by rc as it was received through args. If the arg contains any of rc's special characters or whitespace as documented in rc(1), it is quoted and any ' characters are escaped to ''.
The quoted command string is also appended to the dump command.
Fixes #135