Skip to content

fix: add resource limit in gateway.js (CWE-770) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add resource limit in gateway.js (CWE-770) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/gateway.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,14 @@ function createGateway(options) {
const scope = options.scope || 'local';
const bodyLimit = positive(options.bodyLimit, 16 * 1024 * 1024, 'bodyLimit');
const timeoutMs = positive(options.timeoutMs, 120000, 'timeoutMs');
const maxConcurrentUpstream = positive(options.maxConcurrentUpstream, 64, 'maxConcurrentUpstream');
const doFetch = options.fetch || globalThis.fetch;
let upstreamInFlight = 0;
return http.createServer(async (req, res) => {
const controller = new AbortController();
const timer = setTimeout(() => controller.abort(), timeoutMs);
res.on('close', () => { if (!res.writableEnded) controller.abort(); });
let countedUpstream = false;
try {
const path = new URL(req.url, 'http://localhost').pathname;
/* /health is free, like the core serve: a probe must speak without a token. */
Expand All @@ -120,6 +123,9 @@ function createGateway(options) {
}
if (!baseUrl || !((req.method === 'POST' && path === '/v1/chat/completions') || (req.method === 'GET' && path === '/v1/models')))
return send(res, 404, { error: { code: 'NOTJEV_NO_ROUTE', message: 'Unknown gateway route' } });
if (upstreamInFlight >= maxConcurrentUpstream)
return send(res, 429, { error: { code: 'NOTJEV_RATE_LIMITED', message: 'Too many concurrent upstream requests' } });
upstreamInFlight++; countedUpstream = true;
const body = req.method === 'POST' ? await readJson(req, bodyLimit) : undefined;
const upstream = await doFetch(baseUrl + path, { method: req.method, signal: controller.signal,
headers: { 'content-type': 'application/json', ...(options.upstreamApiKey ? { authorization: 'Bearer ' + options.upstreamApiKey } : {}) },
Expand All @@ -140,7 +146,7 @@ function createGateway(options) {
} catch (e) {
if (res.headersSent) res.destroy();
else send(res, e.code === 'NOTJEV_BODY_LIMIT' ? 413 : 400, { error: { code: e.code || 'NOTJEV_GATEWAY_ERROR', message: e.message } });
} finally { clearTimeout(timer); }
} finally { clearTimeout(timer); if (countedUpstream) upstreamInFlight--; }
});
}

Expand Down