Repository navigation
fix(v7): repair end-to-end runtime and dashboard failures - #76
Conversation
| default_db = storage_dir / "daem0nmcp.db" | ||
| return default_db if default_db.is_file() else None | ||
| try: | ||
| return resolve_active_database(storage_dir).path |
There was a problem hiding this comment.
WARNING: The resolved v7 database is WAL-mode, and the connect below opens it with a bare ?mode=ro URI
resolve_active_database() now returns the active generation database (for a migrated store: migrations/v7/<run>/candidate.db), and every Daem0n database is WAL-mode (daem0nmcp/database.py:104). Opening a WAL-mode file read-only without immutable=1 lets SQLite create -wal/-shm sidecars inside the user's storage directory; when it cannot create them the read fails with SQLITE_CANTOPEN, which _load_active_rules swallows, so the hook enforces no rules at all (fail-open).
The repo already has the correct helper in the module this file imports: use sqlite3.connect(readonly_database_uri(db_file), uri=True, timeout=2.0) and add readonly_database_uri to the ..storage_activation import. It adds immutable=1 when no sidecars exist, which is the "offline inspection must leave no sidecars" policy in daem0nmcp/workspace.py:383-390.
| _NATIVE_PROFILE_MODULES = { | ||
| "local": ("qdrant_client",), | ||
| "models-local": ("sentence_transformers", "onnx", "onnxruntime"), | ||
| "local": ("numpy", "qdrant_client"), |
There was a problem hiding this comment.
SUGGESTION: numpy is not declared by the local extra or by PROFILES["local"], so readiness and the preload now disagree
PROFILES["local"].distributions is ("qdrant-client",) (daem0nmcp/capabilities.py:36) and the local extra installs only qdrant-client, yet this tuple now requires numpy to import. The capability registry therefore reports local: ready while the Windows preload additionally demands a working numpy, so the same install reports two different capability states depending on the platform.
Either declare numpy in the local extra and in PROFILES["local"].distributions so both sources agree, or drop numpy from the local tuple and rely on models-local/late-interaction, whose extras do declare it.
| from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import ( | ||
| OTLPSpanExporter, | ||
| ) | ||
| resource = Resource.create({"service.name": "daem0nmcp"}).merge( |
There was a problem hiding this comment.
SUGGESTION: Reuse get_service_name() instead of the hardcoded service name
This module already resolves the service name in one place (get_service_name()), but the resource hardcodes "daem0nmcp" and then re-merges the environment to undo it. Resource.create() already applies OTEL_RESOURCE_ATTRIBUTES and OTEL_SERVICE_NAME, so resource = Resource.create({"service.name": get_service_name()}) yields the same resource (OTEL_SERVICE_NAME wins over OTEL_RESOURCE_ATTRIBUTES per the OTel spec) with one merge instead of two, and the two service-name sources can no longer drift.
| if (data.communities.length && globalThis.D3) { | ||
| const root = globalThis.D3.hierarchy(hierarchy(data)).sum(value => value.value || 0); | ||
| globalThis.D3.treemap().size([960, 540]).padding(3)(root); | ||
| if (data.communities.length && globalThis.d3) { |
There was a problem hiding this comment.
SUGGESTION: A missing D3 bundle now renders "No communities found."
After this fix the else branch is reachable with populated data whenever the bundle fails to load, and it states that there are no communities — a false statement about the data rather than a load failure. Split the conditions: keep "No communities found." for an empty data.communities, and show a distinct message (e.g. "Community map is unavailable.") when globalThis.d3 is missing.
| scope = {"workspace_id": workspace.workspace_id} | ||
| service = f"daem0n-observability-{transport}" | ||
| with _collector(protocol) as (endpoint, messages): | ||
| control = TracerProvider(resource=Resource.create({"service.name": "control"})) |
There was a problem hiding this comment.
SUGGESTION: Make the positive control independent of the ambient OTEL_* environment
server_environment() strips OTEL_* from the child process, but this control provider is built in the parent, where Resource.create() merges the ambient OTEL_SERVICE_NAME/OTEL_RESOURCE_ATTRIBUTES. A CI image that exports them can change the control's service name, and the assertion below then fails with "the collector received nothing" instead of a real diagnosis.
Clear them for the parent before building the control, as tests/test_tracing.py:45-53 already does.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Correctness / Safety FindingsNo correctness or safety findings. Ponytail ReviewPonytail: Lean already. Ship. Ponytail net: 0 lines. Suggested Minimal PatchNo patch needed. Final Merge GuidanceCan merge as-is. Files Reviewed (18 files)
Previous Review Summaries (2 snapshots, latest commit 3771ad5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3771ad5)Status: 1 Issue Found | Recommendation: Merge Overview
Issue Details (click to expand)SUGGESTION
Earlier Findings, Re-Verified Against Current HEAD
Ponytail Review
Ponytail net: -4 lines. Suggested Minimal PatchOne file, one line in message.textContent = data.communities.length
? "Community map is unavailable."
: "No communities found.";Nothing else needs to change. Fix these issues in Kilo Cloud Files Reviewed (18 files)
Previous review (commit 3fc2618)Status: 5 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Ponytail Review
Ponytail net: -6 lines. Suggested Minimal PatchOne file, one line: in Fix these issues in Kilo Cloud Files Reviewed (18 files)
Reviewed by minimax-m3 · Input: 46.7K · Output: 15.4K · Cached: 535.4K Review guidance: REVIEW.md from base branch |
Disposable end-to-end acceptance found four failures in production paths: command reminders read the wrong database generation, configured OTLP tracing exported nothing, Windows task restart could stall loading NumPy in a worker, and populated community/graph dashboards rendered empty because the shipped D3 global name did not match the renderers. This change fixes those paths and adds focused regressions, including real OTLP collectors and tests using the actual shipped D3 bundle.
The pass also adds a real core-gateway counsel/idempotency/restart regression and corrects client documentation to describe the installed remind-only hooks accurately. Detailed evidence and artifact hashes are in
docs/release/v7/acceptance-2026-11-11.md.Validation:
This is functional acceptance, not final-release certification. OpenCode's provider OAuth refresh returns 401 before MCP and requires local reauthentication. Live E2B lacks credentials. Third-party Apps-host compatibility and the release-scale/eight-hour performance gates remain unverified.