Repository navigation
Conversation
… as YAML The unquoted description contained '/legion: commands'; the ': ' makes the frontmatter invalid YAML, so strict loaders (yaml, js-yaml/gray-matter, PyYAML) reject the whole block. Quote the value, refresh checksums, and add a test that parses every skills/*/SKILL.md frontmatter.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/workflow-common-core/SKILL.mdis the only skill whose frontmatter isn't valid YAML. Thedescriptionvalue is unquoted and contains/legion: commands. The:inside a plain scalar starts a nested mapping, so a YAML parser rejects the whole frontmatter block and never readsnameordescription.Repro (on
main@ 30662e3)With the repo's own
yamldependency:gray-matter(dev dependency) fails the same way:incomplete explicit mapping pair; a key node is missed ... at line 3, column 74. None of the other 32skills/*/SKILL.mdfiles fail.Impact
The installer copies this skill to every runtime target. A loader that parses frontmatter strictly will reject or skip it, the same kind of failure as #22. The sibling
summary:field in the same block is already double-quoted, so this one looks like it was missed.Fix
checksums.sha256(npm run checksums:generate), since the file is in the published set.tests/skill-frontmatter.test.js, which parses everyskills/*/SKILL.mdfrontmatter withyamland checks thatname/descriptionare strings.validate.shonly checks agent frontmatter with an awk extractor, so nothing in CI was parsing skill frontmatter.Verification (Node 20.20.2, same as CI)
main(workflow-common-core/SKILL.md frontmatter is not valid YAML) and passes with the fix.npm run validate: PASS 316 / FAIL 0npm run release:check: passednpm run checksums:generate && git diff --exit-code -- checksums.sha256: cleannpm test: 1391 / 1391 pass(On macOS, 12
installer-smokecases fail onmaintoo, becauseos.tmpdir()resolves/varvs/private/vardifferently. They pass withTMPDIRset to a realpath. That's unrelated to this change and doesn't happen on Linux CI.)🤖 Generated with Claude Code