fix: WP 7.0 compat, correct CX ID URL encoding, block.json role - #51
Merged
Conversation
- rawurlencode CX ID in script URL (esc_attr is HTML attr context, not URL context) - Pass null version for external Google CSE script to suppress spurious &ver= query param - Add role:content to block.json so block remains editable inside contentOnly patterns (WP 7.0 default) - Fix stale docblock referencing removed gpse/search-form block - Bump readme.txt changelog to 1.2.6; sync README.md stable tag
acockrell
enabled auto-merge (squash)
June 21, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rawurlencodefor CX ID —esc_attris for HTML attribute context; URL parameters needrawurlencode. CX IDs are alphanumeric so this was benign in practice, but now correct.nullversion for Google CSE script — suppresses the spurious&ver=1.2.5WordPress was appending to the external Google URL. External scripts manage their own versioning.role: contentinblock.json— WordPress 7.0 makescontentOnlymode the default for patterns. Without this, thegpse/search-resultsblock would be hidden/locked when dropped inside a pattern. This keeps it editable.class-wp-gpse-blocks.phpreferenced the removedgpse/search-formblock; updated to reflect onlygpse/search-resultsexists.readme.txt; syncedREADME.mdstable tag from 1.2.3 → 1.2.5.Test plan
make test-phppassescse.google.com/cse.js?cx=<id>with no&ver=appendedgpse/search-resultsblock is editable when placed inside a pattern