chore(): added the webank helm chart provisioning documentation - #13
Open
Arielpetit wants to merge 2 commits into
Open
chore(): added the webank helm chart provisioning documentation#13Arielpetit wants to merge 2 commits into
Arielpetit wants to merge 2 commits into
Conversation
Arielpetit
requested review from
Koufan-De-King,
NkwaTambe,
hanswizzy,
nancymuyeh and
yvanhenang
December 3, 2024 08:32
Koufan-De-King
previously approved these changes
Dec 5, 2024
Koufan-De-King
changed the title
stephane-segning
previously approved these changes
Dec 6, 2024
hanswizzy
previously approved these changes
Dec 9, 2024
stephane-segning
dismissed stale reviews from hanswizzy, Koufan-De-King, and themself
via
December 9, 2024 08:28
362bf74
stephane-segning
requested changes
Dec 11, 2024
stephane-segning
left a comment
stephane-segning
left a comment
Contributor
There was a problem hiding this comment.
Good work, but check these points:
- Here an example of "good" https://github.com/bitnami/charts/blob/main/bitnami/redis/README.md
- Docs related to an app (helm, code, terraform, spring boot, ...) should be into the README.md of the said application. If it's not related, then it can safely go into the
/Docsfolder. - Also, prefer lowercase. Always. Don't
/Docs, do/docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.