security bug fix: Fix malformed Content-Encoding header in json-status upload#2
Open
billmcilhargey wants to merge 1 commit into
Open
security bug fix: Fix malformed Content-Encoding header in json-status upload#2billmcilhargey wants to merge 1 commit into
billmcilhargey wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a malformed HTTP header in the
json-statusupload path. ThecurlPOST was sendingContent_Encoding: gzip(underscore) instead of the RFC-compliantContent-Encoding: gzip(hyphen).Problem
Per RFC 7230 § 3.2, HTTP header field names must use hyphens. While many servers tolerate underscores via fallback parsing, hardened gateways silently drop them — most notably nginx, which defaults to
underscores_in_headers off.When the header is dropped:
Content-Encodingflag.Fix
Single-character change in
json-status(line ~362):