fix(ci): stabilize afi-factory TypeScript build - #4
Merged
Conversation
- Add ignoreDeprecations "6.0" to tsconfig compilerOptions - Pin typescript ~6.0.3 as devDependency and regenerate package-lock.json Verified: npm ci && npm run build && npm test && npm run typecheck all pass; committed dist/ is unchanged after rebuild. Co-authored-by: Giovanni <founder@afiprotocol.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the afi-factory TypeScript build by pinning a supported TypeScript version and silencing the TS6/Node10 deprecation warning that breaks CI.
Changes
tsconfig.json: Add"ignoreDeprecations": "6.0"tocompilerOptionsto acknowledge themoduleResolution: "node"(node10) deprecation and allow the build to proceed under TypeScript 6.x.package.json: Addtypescript: "~6.0.3"as adevDependencyto pin the compiler used by CI.package-lock.json: Regenerated to locktypescript@6.0.3.Verification
All of the following pass locally:
The committed
dist/artifacts are unchanged after rebuild (git diff -- dist/is empty); onlypackage.json,package-lock.json, andtsconfig.jsonare modified.