fix(GeneralizationStage): forward crashes to objective feedback during gap probing#3738
Open
k5602 wants to merge 1 commit intoAFLplusplus:mainfrom
Open
fix(GeneralizationStage): forward crashes to objective feedback during gap probing#3738k5602 wants to merge 1 commit intoAFLplusplus:mainfrom
k5602 wants to merge 1 commit intoAFLplusplus:mainfrom
Conversation
…izationStage verify_input called executor.run_target() directly and silently discarded any ExitKind::Crash / Timeout / Oom result. Crashes found while probing gap candidates were never forwarded to objective feedback and therefore never added to the solutions corpus. Fix: after post_exec_all, if exit_kind != ExitKind::Ok, delegate to fuzzer.evaluate_execution() with send_events=true so objective/corpus feedback runs through the canonical pipeline, then return Ok(false) to halt generalization on the failing input. Propagate the required Z: ExecutionProcessor<...> bound to the Stage impl where-clause and to find_gaps / find_gaps_in_closures, which also call verify_input on every reduced candidate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GeneralizationStage::verify_inputexecuted candidate inputs viaexecutor.run_target()but never checked the returnedExitKind.Crash,Timeout, andOomresults were silently discarded.Because
verify_inputis called once for stability checking and thenon every intermediate candidate inside
find_gaps(12 passes) andfind_gaps_in_closures(6 passes), the blind spot covered the entiregeneralization phase — any input that triggered a new crash during
simplification would not be added to the solutions corpus.
Fix: After
post_exec_all, checkexit_kind != ExitKind::Okandforward the run to
fuzzer.evaluate_execution(…, send_events: true),identical to the pattern used in
StdTMinMutationalStage. Then returnOk(false)to abort generalization for that input.Trait bounds added:
Z: ExecutionProcessor<EM, BytesInput, E::Observers, S>on theStageimpl,verify_input,find_gaps, andfind_gaps_in_closureswhere-clauses (ordered alphabetically per project convention).
No behavior change for
ExitKind::Okruns.Checklist
./scripts/precommit.shand addressed all commentsFixes #3288