PoC using polib and how to silent padpo on false positives#64
Open
christopheNan wants to merge 15 commits intoAFPy:masterfrom
Open
PoC using polib and how to silent padpo on false positives#64christopheNan wants to merge 15 commits intoAFPy:masterfrom
christopheNan wants to merge 15 commits intoAFPy:masterfrom
Conversation
…tives POC in relation with AFPy#61 polib: * replacement of padpo parser by polib parser is done with minimal change of the structure of padpo. Refactoring would be welcome. * linelength checker is deleted as polib does not provide msgstr in vanilla form. Job can be done by powrap * changes validated only on test files! silent padpo: * 2 tags are provided as a POC: 1 for glossary and 1 for nbsp * polib is needed as padpo parser does not provide access to 'translator comment' field.
May not be the best way to do it as it does not use the *warning* instance returned by Grammalecte. The filter_out functions may be more appropriate but they do not access the tcomment field. --> would be nice to refactor to get the best of the two approaches.
christopheNan
force-pushed
the
using_polib_poc
branch
from
f9e6926 to
229874a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC in relation with #61
polib:
the structure of padpo. Refactoring would be welcome.
form.
Job can be done by powrap
silent padpo:
comment' field.