Fix nested confirmation dialog layering - #24
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Transactions delete confirmation rendering underneath the open Edit transaction sheet.
The edit flow uses
AdaptiveSheet, which is portaled at z-index 80, whileConfirmDialogwas rendered in-place at z-index 50. That made the destructive confirmation visually appear behind the editor. The two document-level focus/Escape handlers could also compete when both dialogs were open.Changes
ConfirmDialogtodocument.bodySafety
Verification
Ravel CI will run lint, typecheck, unit tests, dependency audits, build, route smoke, and the Playwright browser suite including the new nested-dialog regression.