Add LaunchScreen with RettLogo on black background#3
Open
julien-fieschi wants to merge 1 commit into
Open
Conversation
- RettLogo.imageset scaffold (@1x/@2x/@3x) — user drops PNGs in RettApp/Resources/Assets.xcassets/RettLogo.imageset/ - LaunchScreen.storyboard: black background, 240×240 logo centered at y·0.85, "Association Française du Syndrome de Rett" in ultra-light system 18pt white below, "© AFSR, 2026" in thin 13pt white 70% under - Info.plist: replace UILaunchScreen dict with UILaunchStoryboardName = "LaunchScreen" - project.yml + generator: drop the old INFOPLIST_KEY_UILaunchScreen_Generation, include the storyboard as a target resource https://claude.ai/code/session_0162vPt6R1byCQb5WL3fY1Gt
nanocorpintl
pushed a commit
that referenced
this pull request
May 17, 2026
Critical regressions from Phase 1 medication rework (issue #10): #1 / #2 / #3: 'First tap on med opens new med, second tap edits; journal pollutes with phantom meds' Root cause: sheet(isPresented:) + separate @State for 'editing'. SwiftUI evaluates the sheet body before the editing @State has propagated, so the first tap captures editing=nil and shows the editor in create mode — saving creates a duplicate med. Switch to sheet(item:) with an EditorSheet enum (.create | .edit(Medication)) that carries the medication value through the sheet identity, so the body always sees the right value on first tap. #4: 'Can't dismiss keyboard, no save button on intake editor' - MedicationEditor + MedicationIntakeEditorView each got a ToolbarItemGroup(placement: .keyboard) with an 'OK' button so the decimal-pad keyboard can be dismissed (no return key on .decimalPad). - MedicationIntakeEditorView now exposes an explicit 'OK' button in the navigation toolbar that dismisses the navigation step. Mutations were already auto-propagated to the parent via mutate(), but the user expected an explicit commit affordance. #8: 'Cannot delete a medication' Add an explicit destructive 'Supprimer ce médicament' section at the bottom of MedicationEditor (only visible in edit mode), guarded by a confirmation dialog. Wired via a new onDelete callback on the editor, called from the parent plan view's deleteMedication helper. The swipe-to-delete in the list stays available. #9: 'Plan accessible from child profile in settings' ChildProfileEditor gains a NavigationLink to MedicationPlanView with a contextual footer mentioning the child's first name. Out of scope, to discuss separately: - #5 BDPM medication database integration - #7 Versioned medication plan with history Both are large features that need their own design pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.