Repository navigation
fix: resolve 8 codebase inconsistencies from Feb 2026 audit - #41
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace self._initialized = False / if self._initialized pattern with hasattr check so the guard actually fires on re-initialization. Also adds reset_singleton fixture to TestIntegration to prevent cross-test singleton leakage now that the guard is effective. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…003) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all actionable inconsistencies from the Feb 2026 codebase audit (
docs/system/INCONSISTENCIES.md).Python Sidecar (critical/high):
toggle_plugin()was writing.vault.tomlas JSON, corrupting it on every toggle. Fixed to usetomli_w.dump._initializedset to False then immediately checked). Fixed withhasattrcheck.register_command(override=False)warned but still overwrote. Now raisesCommandRegistrationError.kwargs.get("p") or kwargs.get("params")fallback blocks. Flat kwargs is now the only calling convention.Rust Backend:
search_pluginsandget_plugin_detailsstub commands (returned empty/error, never implemented).is_running()dead method; removed#[allow(dead_code)]fromget_active_windows()(kept — exercised by a unit test).Frontend:
loadHistory()accessedres.resultwithout checking for error responses. Added early-return guard.Test Plan
pixi run test)pixi run test-rust)npm run test)docs/system/INCONSISTENCIES.mdwith commit refs🤖 Generated with Claude Code