Fix two critical firmware bugs: RISC-V interrupt CSR and TIM1 CH2 PWM config#1
Draft
Copilot wants to merge 2 commits into
Draft
Fix two critical firmware bugs: RISC-V interrupt CSR and TIM1 CH2 PWM config#1Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Review untested firmware and fix issues
Fix two critical firmware bugs: RISC-V interrupt CSR and TIM1 CH2 PWM config
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the untested CH32V003 firmware that would prevent it from compiling or running correctly.
Bug 1 — Wrong CSR in interrupt helpers (
primask→mstatus)irq_lock/irq_restoreused ARM Cortex-M'sprimaskregister — this doesn't exist on RISC-V and causes a compile error. Fixed to use RISC-Vmstatuswith the MIE bit (bit 3) via an atomiccsrrci/csrsipair.Bug 2 — TIM1 CH2 configured via wrong register (
CHCTLR2→CHCTLR1upper byte)TIM1->CHCTLR2was written to set up Fan 2's PWM output. On CH32V003,CHCTLR2maps to channels 3 & 4 — channel 2 lives in the upper byte ofCHCTLR1. Fan 2 (PD6) was left in reset "frozen" mode, producing no PWM signal.Original prompt
Created from VS Code.