Skip to content

Move Maxtext layers and models.#3054

Open
dipannita08 wants to merge 1 commit intomainfrom
move-maxtext-layers-2
Open

Move Maxtext layers and models.#3054
dipannita08 wants to merge 1 commit intomainfrom
move-maxtext-layers-2

Conversation

@dipannita08
Copy link
Collaborator

@dipannita08 dipannita08 commented Jan 30, 2026

Description

Move maxtext layers and models.

Tests

  • Unit tests
  • Github CI

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 96.58537% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/encoders.py 33.33% 4 Missing ⚠️
src/MaxText/layerwise_quantization.py 0.00% 2 Missing ⚠️
src/MaxText/integration/tunix/tunix_adapter.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from 3cf7126 to 38e28fd Compare February 6, 2026 04:53
@dipannita08 dipannita08 changed the title Move src/MaxText/layers to src/maxtext/layers Move src/MaxText/layers to src/maxtext/layers and src/maxtext/models Feb 6, 2026
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from 38e28fd to 737f520 Compare February 6, 2026 06:00
@dipannita08 dipannita08 changed the title Move src/MaxText/layers to src/maxtext/layers and src/maxtext/models Move Maxtext layers and models. Feb 6, 2026
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from 9010038 to 581c5d3 Compare February 7, 2026 00:24
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch 4 times, most recently from ff42f6b to e403509 Compare February 13, 2026 00:47
@dipannita08 dipannita08 force-pushed the move-maxtext-layers-2 branch from d25d480 to ac6ba4a Compare February 19, 2026 04:00
dipannita08 added a commit that referenced this pull request Feb 19, 2026
Imported from GitHub PR #3054

# Description

Move maxtext layers and models.

# Tests

- Unit tests
- Github CI

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

# Checklist

Before submitting this PR, please make sure (put X in square brackets):
- [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label.
- [x] I have necessary comments in my code, particularly in hard-to-understand areas.
- [x] I have run end-to-end tests tests and provided workload links above if applicable.
- [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files).

Copybara import of the project:

--
ac6ba4a by Dipannita Shaw <dishaw@google.com>:

Move layers and models into new folders

Merging this change closes #3054

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3054 from AI-Hypercomputer:move-maxtext-layers-2 ac6ba4a
PiperOrigin-RevId: 869911746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments