Migrate PlaceHolderDataIterator from tf to np#3149
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
🤖 Hi @aireenmei, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
📋 Review Summary
This pull request effectively migrates the synthetic data generator from TensorFlow to NumPy, successfully removing a key dependency. The implementation is clean, straightforward, and achieves the stated goal.
🔍 General Feedback
- The change is well-executed and improves the project by decoupling it from TensorFlow for this component.
- The new implementation using a Python generator is a simple and efficient solution for providing placeholder data.
7e3e974 to
c353668
Compare
NuojCheng
approved these changes
Feb 18, 2026
NicoGrande
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part of the plan of removing TF dependency in MaxText.
Also fix a bug caused by expansion_factor_real_data is type float but some places expect int.
Tests
Tested with the following script, set
max_checkify=trueto error out if training batch contains -1 batch produced by PlaceHolderDataIteratorcloud log
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.