Skip to content

Refactor Github Action per b/485167538 #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-admin wants to merge 1 commit into from
+12 −6
Closed

Refactor Github Action per b/485167538 #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/RunTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
STEPS_FIND_ISSUE_OUTPUTS_ISSUE_NUMBER: ${{ steps.find_issue.outputs.issue_number }}
run: |
ISSUE_NUMBER=${{ steps.find_issue.outputs.issue_number }}
ISSUE_NUMBER=${STEPS_FIND_ISSUE_OUTPUTS_ISSUE_NUMBER}
LABELS=$(gh issue view $ISSUE_NUMBER --json labels -q '.labels[].name')

if echo "$LABELS" | grep -q "success-run-2"; then
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/run_tests_against_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,25 @@ jobs:
- name: Run Tests
shell: bash
run: |
if [ "${{ inputs.is_scheduled_run }}" == "true" ]; then
FINAL_PYTEST_MARKER="${{ inputs.pytest_marker }}"
if [ "${INPUTS_IS_SCHEDULED_RUN}" == "true" ]; then
FINAL_PYTEST_MARKER="${INPUTS_PYTEST_MARKER}"
else
FINAL_PYTEST_MARKER="${{ inputs.pytest_marker }} and not scheduled_only"
FINAL_PYTEST_MARKER="${INPUTS_PYTEST_MARKER} and not scheduled_only"
fi
# TODO: Use package data for testing and remove the env vars
export MAXTEXT_REPO_ROOT=$(pwd)
export MAXTEXT_ASSETS_ROOT=$(pwd)/src/MaxText/assets
export MAXTEXT_TEST_ASSETS_ROOT=$(pwd)/src/MaxText/test_assets
export MAXTEXT_PKG_DIR=$(pwd)/src/MaxText
# omit this libtpu init args for gpu tests
if [ "${{ inputs.device_type }}" != "cuda12" ]; then
if [ "${INPUTS_DEVICE_TYPE}" != "cuda12" ]; then
export LIBTPU_INIT_ARGS='--xla_tpu_scoped_vmem_limit_kib=65536'
fi
# TODO: Fix the skipped tests and remove the deselect flags
[ "${{ inputs.total_workers }}" -gt 1 ] && .venv/bin/python3 -m pip install --quiet pytest-split && SPLIT_ARGS="--splits ${{ inputs.total_workers }} --group ${{ inputs.worker_group }}" || SPLIT_ARGS=""
.venv/bin/python3 -m pytest ${{ inputs.pytest_addopts }} -v -m "${FINAL_PYTEST_MARKER}" --durations=0 --deselect "tests/aot_hlo_identical_test.py::AotHloIdenticalTest::test_default_hlo_match" --deselect "tests/tokenizer_test.py::TokenizerTest::test_detokenize" $SPLIT_ARGS
.venv/bin/python3 -m pytest ${INPUTS_PYTEST_ADDOPTS} -v -m "${FINAL_PYTEST_MARKER}" --durations=0 --deselect "tests/aot_hlo_identical_test.py::AotHloIdenticalTest::test_default_hlo_match" --deselect "tests/tokenizer_test.py::TokenizerTest::test_detokenize" $SPLIT_ARGS
env:
INPUTS_IS_SCHEDULED_RUN: ${{ inputs.is_scheduled_run }}
INPUTS_PYTEST_MARKER: ${{ inputs.pytest_marker }}
INPUTS_DEVICE_TYPE: ${{ inputs.device_type }}
INPUTS_PYTEST_ADDOPTS: ${{ inputs.pytest_addopts }}
Loading