Move RL code from src/MaxText/rl/ to src/maxtext/trainers/post_train/rl/#3180
Open
Move RL code from src/MaxText/rl/ to src/maxtext/trainers/post_train/rl/#3180
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Feb 18, 2026
hengtaoguo
approved these changes
Feb 18, 2026
bvandermoon
approved these changes
Feb 18, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
For the manual tests you ran, could you also try with the old commands? Not as critical as the train.py shims since RL is a newer feature, but still good to test them since they are added here
Collaborator
Author
|
Done testing with the old command and updated the description - thanks @bvandermoon |
ec30219 to
81e5072
Compare
81e5072 to
8918852
Compare
Collaborator
Thanks @A9isha. Just to double check, can you confirm you saw all logs as expected with the old command? For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate RL training code to the new package structure following the same pattern as the SFT (PR #2988) and distillation moves. Old location files are replaced with backward-compatibility shims that delegate to the new modules with deprecation warnings.
Tests
Locally ran RL using the following commands:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.