Skip to content

[WIP] NNX in logits check, workaround#3188

Draft
hengtaoguo wants to merge 1 commit intomainfrom
hengtaoguo-nnx-logits
Draft

[WIP] NNX in logits check, workaround#3188
hengtaoguo wants to merge 1 commit intomainfrom
hengtaoguo-nnx-logits

Conversation

@hengtaoguo
Copy link
Collaborator

@hengtaoguo hengtaoguo commented Feb 18, 2026

Description

Demo only, DO NOT merge.

It loads the full NNX ckpt using orbax API, unwrap the "base/value", and then apply the correct mesh to the params.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@hengtaoguo hengtaoguo changed the title NNX in logits check, workaround [WIP] NNX in logits check, workaround Feb 18, 2026
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/utils/model_creation_utils.py 0.00% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments