Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py#3189
Open
bvandermoon wants to merge 1 commit intomainfrom
Open
Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py#3189bvandermoon wants to merge 1 commit intomainfrom
bvandermoon wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
04c414f to
f6d1961
Compare
f6d1961 to
63ed9cb
Compare
hengtaoguo
approved these changes
Feb 19, 2026
Collaborator
hengtaoguo
left a comment
There was a problem hiding this comment.
Thanks for the restructuring!
Collaborator
There was a problem hiding this comment.
Out of curiosity, why do we still keep a train.py under MaxText?
| if __name__ == "__main__": | ||
| app.run(main) | ||
| try: | ||
| logging.set_verbosity(logging.INFO) |
Collaborator
There was a problem hiding this comment.
What does this code snippet do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MaxText/train.pytomaxtext/trainers/pre_train/train.pyMaxText/train.pyto support old command. Include a deprecation warninghttps://github\.com/AI-Hypercomputer/maxtext/.*trainers/pre_train/train. We can choose to update these links later once the commit id of the actually merged PR is availableTests
Both new and old commands are working as expected:
New command:
Old command:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.