Skip to content

Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py#3189

Open
bvandermoon wants to merge 1 commit intomainfrom
bvandermoon-restructure
Open

Migrate MaxText/train.py to maxtext/trainers/pre_train/train.py#3189
bvandermoon wants to merge 1 commit intomainfrom
bvandermoon-restructure

Conversation

@bvandermoon
Copy link
Collaborator

Description

  • Move MaxText/train.py to maxtext/trainers/pre_train/train.py
  • Create shim in MaxText/train.py to support old command. Include a deprecation warning
    • TODO: Add deprecation dates to this and other shims we are adding
  • Update all old path references in repo
    • Left off links to old file that include a specific commit. Can be found by searching this regex: https://github\.com/AI-Hypercomputer/maxtext/.*trainers/pre_train/train. We can choose to update these links later once the commit id of the actually merged PR is available

Tests

Both new and old commands are working as expected:

New command:

python3 -m maxtext.trainers.pre_train.train src/maxtext/configs/base.yml \
    run_name=<run_name> \
    base_output_directory=gs://<gcs_bucket> \
    dataset_type=synthetic \
    steps=10 \
    enable_checkpointing=false

Old command:

python3 -m MaxText.train src/maxtext/configs/base.yml \
    run_name=<run_name> \
    base_output_directory=gs://<gcs_bucket> \
    dataset_type=synthetic \
    steps=10 \
    enable_checkpointing=false

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copy link
Collaborator

@khatwanimohit khatwanimohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 59.58188% with 116 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/trainers/pre_train/train.py 62.59% 78 Missing and 23 partials ⚠️
src/MaxText/train.py 0.00% 14 Missing ⚠️
src/MaxText/estimator.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@bvandermoon bvandermoon force-pushed the bvandermoon-restructure branch from 04c414f to f6d1961 Compare February 19, 2026 01:11
@bvandermoon bvandermoon force-pushed the bvandermoon-restructure branch from f6d1961 to 63ed9cb Compare February 19, 2026 01:19
Copy link
Collaborator

@hengtaoguo hengtaoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the restructuring!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why do we still keep a train.py under MaxText?

if __name__ == "__main__":
app.run(main)
try:
logging.set_verbosity(logging.INFO)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this code snippet do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments