[Pathways Elastic Training] Ensure one goodput monitoring flush at the end of the workload#3190
Open
dipannita08 wants to merge 1 commit intomainfrom
Open
[Pathways Elastic Training] Ensure one goodput monitoring flush at the end of the workload#3190dipannita08 wants to merge 1 commit intomainfrom
dipannita08 wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
approved these changes
Feb 19, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
LGTM, thanks @dipannita08. Just to confirm my understanding, the final metrics flush will still happen at the end of elastic training, right?
Collaborator
Author
Yes it will still happen at the true end of the workload. |
shauryagup
approved these changes
Feb 19, 2026
shralex
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Elastic restart consists of both the config initialization and run. The final metrics flush (run once at the end of
stop_goodput_uploader) is a one time operation that waits for all metrics to be computed and uploaded, however this is designed to be done at the actual end of the workload - not before an elastic event. This is where the elastic manager wraps the training loop. Doing this delays elastic restarts.FIXES: b/484798225
FIXES: #123456
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.