Update PyTorch Llama3 70B recipe to calculate metrics from profile#29
Open
Update PyTorch Llama3 70B recipe to calculate metrics from profile#29
Conversation
Contributor
|
Very cool work, @bhavya01, do you have plan to add this new metric to Mixtral8_7B too? |
Collaborator
Author
Yes, will do it for Mixtral too |
zpcore
reviewed
Feb 18, 2025
| # Base package containing nightly PyTorch/XLA | ||
| ARG BASE_IMAGE=us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:nightly_3.10_tpuvm | ||
| FROM ${BASE_IMAGE} | ||
| FROM us-central1-docker.pkg.dev/tpu-pytorch-releases/docker/xla:nightly_3.10_tpuvm_cxx11_20250211 |
Collaborator
There was a problem hiding this comment.
Did you try run with the 20250211 base image with the full pod? Context: pytorch/xla#8683
Collaborator
Author
There was a problem hiding this comment.
Good catch! Let me try running on full pod as well.
pgmoka
reviewed
Feb 18, 2025
Comment on lines
+31
to
+32
| (`us-central1-docker.pkg.dev/deeplearning-images/reproducibility/pytorch-xla/llama3-70b:feb14build`). | ||
| The docker image uses torch and torch_xla nightly build from 02/11/2024 |
There was a problem hiding this comment.
Could we not create a label for the currently used test, and then rotate that between different versions? This could avoid possible human error, and removes the requirement to change version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only updated the step time calculation in the branch
[flash_attention_minibatch_v6e](https://github.com/pytorch-tpu/transformers/compare/flash_attention_minibatch_v6e)with the commit pytorch-tpu/transformers@b185651The output of the script looks as follows: