randomizable gripper & extended grippers domain, rewritten in python - #7
Open
guicho271828 wants to merge 2 commits into
Open
guicho271828 wants to merge 2 commits into
guicho271828 wants to merge 2 commits into
Conversation
guicho271828
force-pushed
the
gripper
branch
3 times, most recently
from
November 26, 2021 15:31
3a8107b to
fb74fc9
Compare
guicho271828
changed the title
Closed
guicho271828
force-pushed
the
gripper
branch
from
November 28, 2021 13:24
fb74fc9 to
a538a4b
Compare
jendrikseipp
requested changes
Dec 19, 2021
jendrikseipp
left a comment
jendrikseipp
left a comment
Collaborator
There was a problem hiding this comment.
Can you please add a "make test" test case for both domains?
|
|
||
| parser.add_argument("balls", type=int, help="the number of balls") | ||
| parser.add_argument("--seed", "-s", type=int, help="random seed") | ||
| parser.add_argument("--randomize", "-r", action="store_true", help="randomize the initial state and the goal if present") |
Collaborator
There was a problem hiding this comment.
I think it's better to combine these two options into the --seed option and randomize if --seed is given.
|
|
||
| # Grippers (python) | ||
|
|
||
| usage: gripper.py [-h] [--seed SEED] balls robots grippers rooms |
Collaborator
There was a problem hiding this comment.
Let's rename the file to grippers.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is an unrelated pull request that makes gripper randomizable. The original behavior is the same when additional arguments are not supplied.